Skip to content

Replace minimatch with picomatch#101

Merged
TwitchBronBron merged 1 commit intorokucommunity:masterfrom
elliot-nelson:enelson/picomatch
Oct 3, 2022
Merged

Replace minimatch with picomatch#101
TwitchBronBron merged 1 commit intorokucommunity:masterfrom
elliot-nelson:enelson/picomatch

Conversation

@elliot-nelson
Copy link
Contributor

@elliot-nelson elliot-nelson commented Oct 3, 2022 •
edited
Loading

SUMMARY

  • Remove minimatch dependency (no longer used)
  • Add picomatch dependency (matching version spec for mocha)

DETAILS

When you install roku-deploy in pnpm workspaces in strict mode, you'll get errors at runtime because the source code uses picomatch, but that package isn't declared in the package json (it is transitively installed and hoisted by npm).

Here's my npm why output (should all bubble up to one install):

[email protected]
node_modules/picomatch
  picomatch@"^2.2.1" from the root project
  picomatch@"^2.0.4" from [email protected]
  node_modules/anymatch
    anymatch@"~3.1.2" from [email protected]
    node_modules/chokidar
      chokidar@"3.5.3" from [email protected]
      node_modules/mocha
        dev mocha@"^9.1.3" from the root project
  picomatch@"^2.2.3" from [email protected]
  node_modules/micromatch
    micromatch@"^4.0.4" from [email protected]
    node_modules/fast-glob
      fast-glob@"^3.2.11" from the root project
      fast-glob@"^3.1.1" from [email protected]
      node_modules/globby
        globby@"^11.0.4" from @typescript-eslint/[email protected]
        node_modules/@typescript-eslint/typescript-estree
          @typescript-eslint/typescript-estree@"5.1.0" from @typescript-eslint/[email protected]
          node_modules/@typescript-eslint/experimental-utils
            @typescript-eslint/experimental-utils@"5.1.0" from @typescript-eslint/[email protected]
            node_modules/@typescript-eslint/eslint-plugin
              dev @typescript-eslint/eslint-plugin@"5.1.0" from the root project
          @typescript-eslint/typescript-estree@"5.1.0" from @typescript-eslint/[email protected]
          node_modules/@typescript-eslint/parser
            dev @typescript-eslint/parser@"5.1.0" from the root project
            peer @typescript-eslint/parser@"^5.0.0" from @typescript-eslint/[email protected]
            node_modules/@typescript-eslint/eslint-plugin
              dev @typescript-eslint/eslint-plugin@"5.1.0" from the root project
  picomatch@"^2.2.1" from [email protected]
  node_modules/readdirp
    readdirp@"~3.6.0" from [email protected]
    node_modules/chokidar
      chokidar@"3.5.3" from [email protected]
      node_modules/mocha
        dev mocha@"^9.1.3" from the root project

TESTING

  • Fixes local error in pnpm workspace
  • Unit tests pass

TwitchBronBron
TwitchBronBron approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! I believe this was introduced in #86 (https://github.com/rokucommunity/roku-deploy/pull/86/files#diff-3294a832ea2276e554177e0b3007cc2d401c082912c7fbde49fa09141bf1aed1R5)

@TwitchBronBron TwitchBronBron merged commit de283cf into rokucommunity:master Oct 3, 2022
@TwitchBronBron
Copy link
Member

TwitchBronBron commented Oct 3, 2022

This has been included in v3.9.2 which was just released a moment ago.

@elliot-nelson elliot-nelson deleted the enelson/picomatch branch October 3, 2022 18:21
xgouchet added a commit to DataDog/dd-sdk-roku that referenced this pull request Nov 22, 2022
@xgouchet
Upgrade to Brighterscript 0.60.6
d5a0ba0 
[0.60.6](rokucommunity/brighterscript@v0.60.5...0.60.6)
- 2022-11-08
 - double `super` call transpile in subclasses
([#740](rokucommunity/brighterscript#740))
 - issues with Roku doc scraper and adds missing components
([#736](rokucommunity/brighterscript#736))

[0.60.5](rokucommunity/brighterscript@v0.60.4...0.60.5)
- 2022-11-03
 - Refactor SymbolTable and AST parent logic so that SymbolTables get
their parent symbol table from its own (AstNode)
([#732](rokucommunity/brighterscript#732))
 - Significant performance boost in `validate()` by caching
`getCallableByName`
([#739](rokucommunity/brighterscript#739))
 - Add diagnostic when using namespaces as variables
([#738](rokucommunity/brighterscript#738))
 - Fix crash in `getDefinition`
([#734](rokucommunity/brighterscript#734))

[0.60.4](rokucommunity/brighterscript@v0.60.3...0.60.4)
- 2022-10-28
 - Add `name` to symbol table
([#728](rokucommunity/brighterscript#728))
 - Allow `continue` as local var
([#730](rokucommunity/brighterscript#730))
 - language server semanticToken request now waits until validate
finishes
([#727](rokucommunity/brighterscript#727))

[0.60.3](rokucommunity/brighterscript@v0.60.2...0.60.3)
- 2022-10-20
 - better parse recovery for unknown function parameter types
([#722](rokucommunity/brighterscript#722))

[0.60.2](rokucommunity/brighterscript@v0.60.1...0.60.2)
- 2022-10-18
 - if statement block var bug
([#698](rokucommunity/brighterscript#698))

[0.60.1](rokucommunity/brighterscript@v0.60.0...0.60.1)
- 2022-10-18
 - Beter location for bs1042
([#719](rokucommunity/brighterscript#719))

[0.60.0](rokucommunity/brighterscript@v0.59.0...0.60.0)
- 2022-10-10
 - goto definition for enum statements and enum members
([#715](rokucommunity/brighterscript#715))
 - nested namespace support
([#708](rokucommunity/brighterscript#708))
 - upgrade to
[[email protected]](https://github.com/rokucommunity/roku-deploy/blob/master/CHANGELOG.md#392---2022-10-03).
Notable changes since 3.9.1:
     - Replace minimatch with picomatch
([roku-deploy#101](rokucommunity/roku-deploy#101))
 - fixes signature help resolution for callexpressions
([#707](rokucommunity/brighterscript#707))
 - Fix transpilation of simple else block with leading comment
([#712](rokucommunity/brighterscript#712))
@xgouchet xgouchet mentioned this pull request Nov 22, 2022
Merged
xgouchet added a commit to DataDog/dd-sdk-roku that referenced this pull request Nov 23, 2022
@xgouchet
Upgrade to Brighterscript 0.60.6
c6aa6e5 
[0.60.6](rokucommunity/brighterscript@v0.60.5...0.60.6)
- 2022-11-08
 - double `super` call transpile in subclasses
([#740](rokucommunity/brighterscript#740))
 - issues with Roku doc scraper and adds missing components
([#736](rokucommunity/brighterscript#736))

[0.60.5](rokucommunity/brighterscript@v0.60.4...0.60.5)
- 2022-11-03
 - Refactor SymbolTable and AST parent logic so that SymbolTables get
their parent symbol table from its own (AstNode)
([#732](rokucommunity/brighterscript#732))
 - Significant performance boost in `validate()` by caching
`getCallableByName`
([#739](rokucommunity/brighterscript#739))
 - Add diagnostic when using namespaces as variables
([#738](rokucommunity/brighterscript#738))
 - Fix crash in `getDefinition`
([#734](rokucommunity/brighterscript#734))

[0.60.4](rokucommunity/brighterscript@v0.60.3...0.60.4)
- 2022-10-28
 - Add `name` to symbol table
([#728](rokucommunity/brighterscript#728))
 - Allow `continue` as local var
([#730](rokucommunity/brighterscript#730))
 - language server semanticToken request now waits until validate
finishes
([#727](rokucommunity/brighterscript#727))

[0.60.3](rokucommunity/brighterscript@v0.60.2...0.60.3)
- 2022-10-20
 - better parse recovery for unknown function parameter types
([#722](rokucommunity/brighterscript#722))

[0.60.2](rokucommunity/brighterscript@v0.60.1...0.60.2)
- 2022-10-18
 - if statement block var bug
([#698](rokucommunity/brighterscript#698))

[0.60.1](rokucommunity/brighterscript@v0.60.0...0.60.1)
- 2022-10-18
 - Beter location for bs1042
([#719](rokucommunity/brighterscript#719))

[0.60.0](rokucommunity/brighterscript@v0.59.0...0.60.0)
- 2022-10-10
 - goto definition for enum statements and enum members
([#715](rokucommunity/brighterscript#715))
 - nested namespace support
([#708](rokucommunity/brighterscript#708))
 - upgrade to
[[email protected]](https://github.com/rokucommunity/roku-deploy/blob/master/CHANGELOG.md#392---2022-10-03).
Notable changes since 3.9.1:
     - Replace minimatch with picomatch
([roku-deploy#101](rokucommunity/roku-deploy#101))
 - fixes signature help resolution for callexpressions
([#707](rokucommunity/brighterscript#707))
 - Fix transpilation of simple else block with leading comment
([#712](rokucommunity/brighterscript#712))
xgouchet added a commit to DataDog/dd-sdk-roku that referenced this pull request Nov 23, 2022
@xgouchet
Upgrade to Brighterscript 0.60.6
9929adb 
[0.60.6](rokucommunity/brighterscript@v0.60.5...0.60.6)
- 2022-11-08
 - double `super` call transpile in subclasses
([#740](rokucommunity/brighterscript#740))
 - issues with Roku doc scraper and adds missing components
([#736](rokucommunity/brighterscript#736))

[0.60.5](rokucommunity/brighterscript@v0.60.4...0.60.5)
- 2022-11-03
 - Refactor SymbolTable and AST parent logic so that SymbolTables get
their parent symbol table from its own (AstNode)
([#732](rokucommunity/brighterscript#732))
 - Significant performance boost in `validate()` by caching
`getCallableByName`
([#739](rokucommunity/brighterscript#739))
 - Add diagnostic when using namespaces as variables
([#738](rokucommunity/brighterscript#738))
 - Fix crash in `getDefinition`
([#734](rokucommunity/brighterscript#734))

[0.60.4](rokucommunity/brighterscript@v0.60.3...0.60.4)
- 2022-10-28
 - Add `name` to symbol table
([#728](rokucommunity/brighterscript#728))
 - Allow `continue` as local var
([#730](rokucommunity/brighterscript#730))
 - language server semanticToken request now waits until validate
finishes
([#727](rokucommunity/brighterscript#727))

[0.60.3](rokucommunity/brighterscript@v0.60.2...0.60.3)
- 2022-10-20
 - better parse recovery for unknown function parameter types
([#722](rokucommunity/brighterscript#722))

[0.60.2](rokucommunity/brighterscript@v0.60.1...0.60.2)
- 2022-10-18
 - if statement block var bug
([#698](rokucommunity/brighterscript#698))

[0.60.1](rokucommunity/brighterscript@v0.60.0...0.60.1)
- 2022-10-18
 - Beter location for bs1042
([#719](rokucommunity/brighterscript#719))

[0.60.0](rokucommunity/brighterscript@v0.59.0...0.60.0)
- 2022-10-10
 - goto definition for enum statements and enum members
([#715](rokucommunity/brighterscript#715))
 - nested namespace support
([#708](rokucommunity/brighterscript#708))
 - upgrade to
[[email protected]](https://github.com/rokucommunity/roku-deploy/blob/master/CHANGELOG.md#392---2022-10-03).
Notable changes since 3.9.1:
     - Replace minimatch with picomatch
([roku-deploy#101](rokucommunity/roku-deploy#101))
 - fixes signature help resolution for callexpressions
([#707](rokucommunity/brighterscript#707))
 - Fix transpilation of simple else block with leading comment
([#712](rokucommunity/brighterscript#712))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elliot-nelson @TwitchBronBron